[webkit-reviews] review granted: [Bug 205108] [JSC] Lock-down JSGlobalObject and derived classes in IsoSubspace : [Attachment 385381] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Dec 11 09:17:46 PST 2019


Mark Lam <mark.lam at apple.com> has granted Yusuke Suzuki <ysuzuki at apple.com>'s
request for review:
Bug 205108: [JSC] Lock-down JSGlobalObject and derived classes in IsoSubspace
https://bugs.webkit.org/show_bug.cgi?id=205108

Attachment 385381: Patch

https://bugs.webkit.org/attachment.cgi?id=385381&action=review




--- Comment #7 from Mark Lam <mark.lam at apple.com> ---
Comment on attachment 385381
  --> https://bugs.webkit.org/attachment.cgi?id=385381
Patch

r=me.

Please fix the win bots failure (probably just need a JS_EXPORT_PRIVATE
attribute on 2 functions according to wincairo bot).  The jsc EWS says testapi
is failing.  Looks legit.  Please fix before landing.


More information about the webkit-reviews mailing list