[webkit-reviews] review granted: [Bug 205114] [LFC][Integration] Paint seemingly blank runs (0 width, result of negative letter-spacing) : [Attachment 385391] Patch

[bugzilla-daemon at webkit.org]

Antti Koivisto <koivisto at iki.fi> has granted zalan <zalan at apple.com>'s request
for review:
Bug 205114: [LFC][Integration] Paint seemingly blank runs (0 width, result of
negative letter-spacing)
https://bugs.webkit.org/show_bug.cgi?id=205114

Attachment 385391: Patch

https://bugs.webkit.org/attachment.cgi?id=385391&action=review




--- Comment #3 from Antti Koivisto <koivisto at iki.fi> ---
Comment on attachment 385391
  --> https://bugs.webkit.org/attachment.cgi?id=385391
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=385391&action=review

> Source/WebCore/layout/displaytree/DisplayInlineContent.cpp:40
> +	   if (runRect.intersects(rect) || (runRect.isEmpty() &&
rect.contains(runRect))) {

Empty case can still have width or height. Is it correct to require the entire
width or height be contained in rect?

Maybe you could add FloatRect::intersectsEvenIfEmpty? There is already
uniteEvenIfEmpty.