[webkit-reviews] review granted: [Bug 204882] Add support for scroll behavior relies on ScrollAnimation of the Web process : [Attachment 385369] Non-native-animation-for-review
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Wed Dec 11 02:54:53 PST 2019
Frédéric Wang (:fredw) <fred.wang at free.fr> has granted review:
Bug 204882: Add support for scroll behavior relies on ScrollAnimation of the
Web process
https://bugs.webkit.org/show_bug.cgi?id=204882
Attachment 385369: Non-native-animation-for-review
https://bugs.webkit.org/attachment.cgi?id=385369&action=review
--- Comment #28 from Frédéric Wang (:fredw) <fred.wang at free.fr> ---
Comment on attachment 385369
--> https://bugs.webkit.org/attachment.cgi?id=385369
Non-native-animation-for-review
View in context: https://bugs.webkit.org/attachment.cgi?id=385369&action=review
OK LGTM. Again, it would be good to have advice from another reviewer, as I
wrote part of this patch.
> Source/WebCore/page/scrolling/AsyncScrollingCoordinator.cpp:266
> +
I think that part is a no-op until we add a third scrollbehaviorstatus. Should
it be moved to the other patch?
More information about the webkit-reviews
mailing list