[webkit-reviews] review granted: [Bug 205100] [WebAuthn] Implement dummy _WKWebAuthenticationPanel SPIs for CTAP PIN support : [Attachment 385348] Patch

[bugzilla-daemon at webkit.org]

Brent Fulgham <bfulgham at webkit.org> has granted Jiewen Tan
<jiewen_tan at apple.com>'s request for review:
Bug 205100: [WebAuthn] Implement dummy _WKWebAuthenticationPanel SPIs for CTAP
PIN support
https://bugs.webkit.org/show_bug.cgi?id=205100

Attachment 385348: Patch

https://bugs.webkit.org/attachment.cgi?id=385348&action=review




--- Comment #3 from Brent Fulgham <bfulgham at webkit.org> ---
Comment on attachment 385348
  --> https://bugs.webkit.org/attachment.cgi?id=385348
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=385348&action=review

I  think this looks good. Did you run it by Garrett? R=me

> Source/WebKit/UIProcess/API/Cocoa/_WKWebAuthenticationPanel.h:71
> +- (void)panel:(_WKWebAuthenticationPanel *)panel
requestPINWithRetries:(NSUInteger)retries completionHandler:(void (^)(NSData
*))completionHandler WK_API_AVAILABLE(macos(WK_MAC_TBA), ios(WK_IOS_TBA));

Do you need a stub implementation to build cleanly?