[webkit-reviews] review granted: [Bug 205086] Worklist::deleteCancelledPlansForVM() should not assume that a cancelled plan is ready for deletion. : [Attachment 385319] proposed patch.

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Dec 10 17:34:42 PST 2019


Saam Barati <sbarati at apple.com> has granted Mark Lam <mark.lam at apple.com>'s
request for review:
Bug 205086: Worklist::deleteCancelledPlansForVM() should not assume that a
cancelled plan is ready for deletion.
https://bugs.webkit.org/show_bug.cgi?id=205086

Attachment 385319: proposed patch.

https://bugs.webkit.org/attachment.cgi?id=385319&action=review




--- Comment #5 from Saam Barati <sbarati at apple.com> ---
Comment on attachment 385319
  --> https://bugs.webkit.org/attachment.cgi?id=385319
proposed patch.

View in context: https://bugs.webkit.org/attachment.cgi?id=385319&action=review

> Source/JavaScriptCore/dfg/DFGWorklist.cpp:323
>	   RELEASE_ASSERT(plan->stage() == Plan::Cancelled);

should we make this a debug assert like before?


More information about the webkit-reviews mailing list