[webkit-reviews] review granted: [Bug 205042] [CMake] Add HarfBuzz targets : [Attachment 385316] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Tue Dec 10 17:23:32 PST 2019
Konstantin Tokarev <annulen at yandex.ru> has granted Don Olmstead
<don.olmstead at sony.com>'s request for review:
Bug 205042: [CMake] Add HarfBuzz targets
https://bugs.webkit.org/show_bug.cgi?id=205042
Attachment 385316: Patch
https://bugs.webkit.org/attachment.cgi?id=385316&action=review
--- Comment #12 from Konstantin Tokarev <annulen at yandex.ru> ---
Comment on attachment 385316
--> https://bugs.webkit.org/attachment.cgi?id=385316
Patch
View in context: https://bugs.webkit.org/attachment.cgi?id=385316&action=review
> Source/cmake/FindHarfBuzz.cmake:31
> +# HarfBuzz_INCLUDE_DIRS - containg the HarfBuzz headers
You still have DIRS here and DIR in code, it needs to be consistent
More information about the webkit-reviews
mailing list