[webkit-reviews] review granted: [Bug 204770] [iOS] Calls to the device motion API should be done in the UI process : [Attachment 385285] Patch

[bugzilla-daemon at webkit.org]

Brent Fulgham <bfulgham at webkit.org> has granted Per Arne Vollan
<pvollan at apple.com>'s request for review:
Bug 204770: [iOS] Calls to the device motion API should be done in the UI
process
https://bugs.webkit.org/show_bug.cgi?id=204770

Attachment 385285: Patch

https://bugs.webkit.org/attachment.cgi?id=385285&action=review




--- Comment #7 from Brent Fulgham <bfulgham at webkit.org> ---
Comment on attachment 385285
  --> https://bugs.webkit.org/attachment.cgi?id=385285
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=385285&action=review

r=me, but please consider changing those bare pointers (perhaps even in a
follow-up patch).

> Source/WebCore/platform/ios/DeviceMotionClientIOS.h:55
> +    DeviceMotionController* m_controller { nullptr };

I'm a little suspicious of these bare pointers. Could they be WeakPtrs?