[webkit-reviews] review granted: [Bug 205021] Move WKWebView code related to testing to new files, with their own headers, and stop exposing test-only functions as SPI. : [Attachment 385315] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Dec 10 16:34:03 PST 2019


Tim Horton <thorton at apple.com> has granted Simon Fraser (smfr)
<simon.fraser at apple.com>'s request for review:
Bug 205021: Move WKWebView code related to testing to new files, with their own
headers, and stop exposing test-only functions as SPI.
https://bugs.webkit.org/show_bug.cgi?id=205021

Attachment 385315: Patch

https://bugs.webkit.org/attachment.cgi?id=385315&action=review




--- Comment #9 from Tim Horton <thorton at apple.com> ---
Comment on attachment 385315
  --> https://bugs.webkit.org/attachment.cgi?id=385315
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=385315&action=review

rs=me

> Source/WebKit/UIProcess/API/Cocoa/WKWebViewTesting.h:52
> + at property (nonatomic, readonly) BOOL _hasInspectorFrontend;

Keep properties separate!


More information about the webkit-reviews mailing list