[webkit-reviews] review granted: [Bug 205089] Fix API test failure after r253351 : [Attachment 385313] Patch

[bugzilla-daemon at webkit.org]

Brent Fulgham <bfulgham at webkit.org> has granted Per Arne Vollan
<pvollan at apple.com>'s request for review:
Bug 205089: Fix API test failure after r253351
https://bugs.webkit.org/show_bug.cgi?id=205089

Attachment 385313: Patch

https://bugs.webkit.org/attachment.cgi?id=385313&action=review




--- Comment #4 from Brent Fulgham <bfulgham at webkit.org> ---
Comment on attachment 385313
  --> https://bugs.webkit.org/attachment.cgi?id=385313
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=385313&action=review

r=me

>>> Tools/TestWebKitAPI/Tests/WebKitCocoa/ContentFiltering.mm:392
>>> +	 method_setImplementation(method,
reinterpret_cast<IMP>(filterRequired));
>> 
>> Could we have other clients that might need this? Or is this truly just a
case of our test infrastructure needing this turned on.
>> 
>> How do client applications that will need content filtering signal this fact
(e.g., Safari) opt into this feature?
> 
> I don't believe other clients need this. The API test is testing whether the
network extension framework is loaded in the WebContent process, and the patch
in r253351 avoids loading the framework unless it is needed, introducing the
failure. The test fix swizzles [NEFilterSource filterRequired] in the UI
process, which will cause the framework to be loaded in the WebContent process.
> 
> Thanks for reviewing!

Sounds good.