[webkit-reviews] review granted: [Bug 204967] Make it possible to add regression tests for blocked XPC services : [Attachment 385167] Patch

[bugzilla-daemon at webkit.org]

Brent Fulgham <bfulgham at webkit.org> has granted Per Arne Vollan
<pvollan at apple.com>'s request for review:
Bug 204967: Make it possible to add regression tests for blocked XPC services
https://bugs.webkit.org/show_bug.cgi?id=204967

Attachment 385167: Patch

https://bugs.webkit.org/attachment.cgi?id=385167&action=review




--- Comment #9 from Brent Fulgham <bfulgham at webkit.org> ---
Comment on attachment 385167
  --> https://bugs.webkit.org/attachment.cgi?id=385167
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=385167&action=review

R=me

>>> Source/WebCore/testing/Internals.cpp:5337
>>> +	 if (process == "com.apple.WebKit.WebContent")
>> 
>> What about WebContent.Development?
> 
> This string will be passed from the layout test html file, and will be the
same for both debug and release builds, so I don't think we need to include a
check for WebContent.Development in this case.
> 
> Thanks for reviewing!

Very good!