[webkit-reviews] review denied: [Bug 205015] Navigation from empty page doesn't use cached web process : [Attachment 385162] Patch

[bugzilla-daemon at webkit.org]

Chris Dumez <cdumez at apple.com> has denied Ben Nham <nham at apple.com>'s request
for review:
Bug 205015: Navigation from empty page doesn't use cached web process
https://bugs.webkit.org/show_bug.cgi?id=205015

Attachment 385162: Patch

https://bugs.webkit.org/attachment.cgi?id=385162&action=review




--- Comment #4 from Chris Dumez <cdumez at apple.com> ---
Comment on attachment 385162
  --> https://bugs.webkit.org/attachment.cgi?id=385162
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=385162&action=review

The patch is not safe as is because it causes a process-swap in cases where we
know it is not OK to process-swap (e.g. when navigation.openedByDOMWithOpener()
returns true). If a page does a window.open() of another, we cannot process
swap due to the opener link.

> Source/WebKit/UIProcess/WebProcessPool.cpp:2142
> +	   if (!targetRegistrableDomain.isEmpty()) {

We should write an API test for this. See existing ProcessSwap API tests.