[webkit-reviews] review granted: [Bug 205030] Regression(r253277) ASSERTION FAILED: !parameters.request.httpBody() in NetworkConnectionToWebProcess::preconnectTo() : [Attachment 385196] Patch

[bugzilla-daemon at webkit.org]

Antti Koivisto <koivisto at iki.fi> has granted Chris Dumez <cdumez at apple.com>'s
request for review:
Bug 205030: Regression(r253277) ASSERTION FAILED:
!parameters.request.httpBody() in NetworkConnectionToWebProcess::preconnectTo()
https://bugs.webkit.org/show_bug.cgi?id=205030

Attachment 385196: Patch

https://bugs.webkit.org/attachment.cgi?id=385196&action=review




--- Comment #2 from Antti Koivisto <koivisto at iki.fi> ---
Comment on attachment 385196
  --> https://bugs.webkit.org/attachment.cgi?id=385196
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=385196&action=review

> Source/WebKit/WebProcess/WebPage/WebPage.cpp:1539
> +	  
WebProcess::singleton().webLoaderStrategy().preconnectTo(ResourceRequest {
loadParameters.request.url() }, *this, *m_mainFrame,
StoredCredentialsPolicy::Use, [](const ResourceError&) { });

It would be nicer to construct the request separately with an informative name
(urlOnlyRequest?) since this is bit non-obvious.

Also didn't you remove the need to give empty lambdas to preconnectTo?