[webkit-reviews] review granted: [Bug 204549] Reduce JSC's binary size : [Attachment 384239] Patch

[bugzilla-daemon at webkit.org]

Saam Barati <sbarati at apple.com> has granted Tadeu Zagallo
<tzagallo at apple.com>'s request for review:
Bug 204549: Reduce JSC's binary size
https://bugs.webkit.org/show_bug.cgi?id=204549

Attachment 384239: Patch

https://bugs.webkit.org/attachment.cgi?id=384239&action=review




--- Comment #3 from Saam Barati <sbarati at apple.com> ---
Comment on attachment 384239
  --> https://bugs.webkit.org/attachment.cgi?id=384239
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=384239&action=review

> Source/JavaScriptCore/ChangeLog:12
> +	   - We were generating 2 instances of dumpBytecode, at 30kb each
> +	   - We had 3 instances of computeUsesForBytecodeIndex at 11kb each
> +	   - We had 8 instances of emit_compareAndJump(Slow) at 8kb (7kb for
Slow) each.

you should say what you actually did. (e.g, made them one instance instead of
N)