[webkit-reviews] review denied: [Bug 204932] Create WebKit API calls for ITP Data : [Attachment 385176] Patch

[bugzilla-daemon at webkit.org]

Sam Weinig <sam at webkit.org> has denied katherine_cheney at apple.com's request for
review:
Bug 204932: Create WebKit API calls for ITP Data
https://bugs.webkit.org/show_bug.cgi?id=204932

Attachment 385176: Patch

https://bugs.webkit.org/attachment.cgi?id=385176&action=review




--- Comment #9 from Sam Weinig <sam at webkit.org> ---
Comment on attachment 385176
  --> https://bugs.webkit.org/attachment.cgi?id=385176
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=385176&action=review

> Source/WebKit/UIProcess/API/Cocoa/WKITPThirdParty.h:31
> + at interface WKITPThirdParty : NSObject

Nice. I like the concrete class much better. 

However, kike with the method, I think it would make sense to stay consistent
here and not use ITP in the name. Also, since this is being exposed as SPI,
this class should start with an _. (Both comments apply to WKITPFirstParty as
well).

> Source/WebKit/UIProcess/API/Cocoa/WKITPThirdParty.h:34
> +- (NSArray<WKITPFirstParty *>
*)getWKITPFirstPartyList:(Vector<WebKit::WebResourceLoadStatisticsStore::ThirdP
artyDataForSpecificFirstParty> *)underFirstParties;
> +- (instancetype)initWithDomain:(NSString *)domain
underFirstParties:(Vector<WebKit::WebResourceLoadStatisticsStore::ThirdPartyDat
aForSpecificFirstParty>&)underFirstParties;

It's not valid to reference WebKit c++ classes from WebKit API/SPI headers. The
model we use is to have a WKITPThirdPartyInternal.h that exposes this, and that
header is not present in the SDK.