[webkit-reviews] review granted: [Bug 205012] Regression(r249329) ViewGestureController::requestRenderTreeSizeNotificationIfNeeded() sometimes uses wrong webPageID for IPC : [Attachment 385158] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Dec 9 10:38:31 PST 2019


Tim Horton <thorton at apple.com> has granted Chris Dumez <cdumez at apple.com>'s
request for review:
Bug 205012: Regression(r249329)
ViewGestureController::requestRenderTreeSizeNotificationIfNeeded() sometimes
uses wrong webPageID for IPC
https://bugs.webkit.org/show_bug.cgi?id=205012

Attachment 385158: Patch

https://bugs.webkit.org/attachment.cgi?id=385158&action=review




--- Comment #3 from Tim Horton <thorton at apple.com> ---
Comment on attachment 385158
  --> https://bugs.webkit.org/attachment.cgi?id=385158
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=385158&action=review

> Source/WebKit/UIProcess/ViewGestureController.cpp:614
> +   
messageSender->send(Messages::ViewGestureGeometryCollector::SetRenderTreeSizeNo
tificationThreshold(threshold));

Kinda sad VGC needs to know about provisional pages at all.


More information about the webkit-reviews mailing list