[webkit-reviews] review granted: [Bug 199782] Streamline PODIntervalTree code and remove ValueToString : [Attachment 385104] Patch

[bugzilla-daemon at webkit.org]

Anders Carlsson <andersca at apple.com> has granted Darin Adler
<darin at apple.com>'s request for review:
Bug 199782: Streamline PODIntervalTree code and remove ValueToString
https://bugs.webkit.org/show_bug.cgi?id=199782

Attachment 385104: Patch

https://bugs.webkit.org/attachment.cgi?id=385104&action=review




--- Comment #16 from Anders Carlsson <andersca at apple.com> ---
Comment on attachment 385104
  --> https://bugs.webkit.org/attachment.cgi?id=385104
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=385104&action=review

> Source/WebCore/platform/PODRedBlackTree.h:104
> +	   insertNode(new Node(T { data }));

Would be nice if insertNode took a unique_ptr - seeing "new" in modern C++ code
always makes me uneasy.