[webkit-reviews] review granted: [Bug 205009] Add support for scroll-behavior's css property and ScrollOptions parsing : [Attachment 385148] Patch

[bugzilla-daemon at webkit.org]

Frédéric Wang (:fredw) <fred.wang at free.fr> has granted	review:
Bug 205009: Add support for scroll-behavior's css property and ScrollOptions
parsing
https://bugs.webkit.org/show_bug.cgi?id=205009

Attachment 385148: Patch

https://bugs.webkit.org/attachment.cgi?id=385148&action=review




--- Comment #2 from Frédéric Wang (:fredw) <fred.wang at free.fr> ---
Comment on attachment 385148
  --> https://bugs.webkit.org/attachment.cgi?id=385148
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=385148&action=review

OK, this LGTM but I don't know if we should land this patch now + I'm the
author of most of this part, so someone else should probably review.

> Source/WebCore/Sources.txt:1755
> +platform/ScrollAnimationSmooth.cpp

That change does not seem necessary for now.

> Source/WebCore/SourcesGTK.txt:-66
> -platform/ScrollAnimationSmooth.cpp

That one either.

> Source/WebCore/rendering/style/StyleRareNonInheritedData.h:178
> +    unsigned useSmoothScrolling : 1; // ScrollBehavior

I wonder if this should be placed somewhere else to optimize bitfield alignment
but I'm not really sure what's the recommendation in WebKit.

> LayoutTests/platform/mac-wk1/TestExpectations:748
> +webkit.org/b/191357
imported/w3c/web-platform-tests/css/cssom-view/inheritance.html [ Skip ]

Maybe skipping that one is not necessary, since it's just css parsing.