[webkit-reviews] review granted: [Bug 205005] enumerateDevices should not expose devices by default if capture persistent setting is set : [Attachment 385143] Patch

[bugzilla-daemon at webkit.org]

Eric Carlson <eric.carlson at apple.com> has granted youenn fablet
<youennf at gmail.com>'s request for review:
Bug 205005: enumerateDevices should not expose devices by default if capture
persistent setting is set
https://bugs.webkit.org/show_bug.cgi?id=205005

Attachment 385143: Patch

https://bugs.webkit.org/attachment.cgi?id=385143&action=review




--- Comment #4 from Eric Carlson <eric.carlson at apple.com> ---
Comment on attachment 385143
  --> https://bugs.webkit.org/attachment.cgi?id=385143
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=385143&action=review

> Source/WebCore/dom/Document.cpp:7815
> +    if (this == &topDocument ||
topDocument.securityOrigin().isSameOriginAs(securityOrigin())) {

Nit: the "this == &topDocument" isn't necessary

> Source/WebCore/dom/Document.cpp:7825
> +    if (this == &topDocument ||
topDocument.securityOrigin().isSameOriginAs(securityOrigin()))

Ditto.

> Tools/ChangeLog:9
> +2019-12-09  youenn fablet  <youenn at apple.com>
> +
> +	   enumerateDevices should not expose devices by default if capture
persistent setting is set
> +	   https://bugs.webkit.org/show_bug.cgi?id=205005
> +
> +	   Reviewed by NOBODY (OOPS!).
> +
> +
> +2019-12-09  youenn fablet  <youenn at apple.com>

Nit: two entries