[webkit-reviews] review granted: [Bug 204992] Preconnect to server as early as possible in WebPage::LoadRequest : [Attachment 385113] Patch

[bugzilla-daemon at webkit.org]

Antti Koivisto <koivisto at iki.fi> has granted Chris Dumez <cdumez at apple.com>'s
request for review:
Bug 204992: Preconnect to server as early as possible in WebPage::LoadRequest
https://bugs.webkit.org/show_bug.cgi?id=204992

Attachment 385113: Patch

https://bugs.webkit.org/attachment.cgi?id=385113&action=review




--- Comment #6 from Antti Koivisto <koivisto at iki.fi> ---
Comment on attachment 385113
  --> https://bugs.webkit.org/attachment.cgi?id=385113
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=385113&action=review

> Source/WebKit/WebProcess/WebPage/WebPage.cpp:1531
> +	  
WebProcess::singleton().webLoaderStrategy().preconnectTo(ResourceRequest {
loadParameters.request }, *this, *m_mainFrame, StoredCredentialsPolicy::Use,
[](const ResourceError&) { });

WTF::Function is a nullable type. Another option would be to make preconnectTo
handle a null callback function and remove the need to construct a no-op
lambda.