[webkit-reviews] review granted: [Bug 204977] REGRESSION(r253231): Debug assertion failures under ~WebDeviceOrientationUpdateProvider(Proxy) : [Attachment 385085] Patch v2

[bugzilla-daemon at webkit.org]

Per Arne Vollan <pvollan at apple.com> has granted David Quesada
<david_quesada at apple.com>'s request for review:
Bug 204977: REGRESSION(r253231): Debug assertion failures under
~WebDeviceOrientationUpdateProvider(Proxy)
https://bugs.webkit.org/show_bug.cgi?id=204977

Attachment 385085: Patch v2

https://bugs.webkit.org/attachment.cgi?id=385085&action=review




--- Comment #4 from Per Arne Vollan <pvollan at apple.com> ---
Comment on attachment 385085
  --> https://bugs.webkit.org/attachment.cgi?id=385085
Patch v2

View in context: https://bugs.webkit.org/attachment.cgi?id=385085&action=review

Thanks for fixing this! R=me.

>
Source/WebKit/WebProcess/WebCoreSupport/WebDeviceOrientationUpdateProvider.cpp:
49
> +   
WebProcess::singleton().removeMessageReceiver(Messages::WebDeviceOrientationUpd
ateProvider::messageReceiverName(), m_pageIdentifier);

The WebPage is already being stored, could you call m_page.identifier()
instead?

>
Source/WebKit/WebProcess/WebCoreSupport/WebDeviceOrientationUpdateProvider.h:57
> +    WebCore::PageIdentifier m_pageIdentifier;

Is this member needed, if you get the identifier from m_page?