[webkit-reviews] review granted: [Bug 204954] Web Inspector: non-regex Local Overrides and Script Blackboxing shouldn't apply to scripts that just contain the URL : [Attachment 385048] Patch

[bugzilla-daemon at webkit.org]

Joseph Pecoraro <joepeck at webkit.org> has granted Devin Rousso
<drousso at apple.com>'s request for review:
Bug 204954: Web Inspector: non-regex Local Overrides and Script Blackboxing
shouldn't apply to scripts that just contain the URL
https://bugs.webkit.org/show_bug.cgi?id=204954

Attachment 385048: Patch

https://bugs.webkit.org/attachment.cgi?id=385048&action=review




--- Comment #6 from Joseph Pecoraro <joepeck at webkit.org> ---
Comment on attachment 385048
  --> https://bugs.webkit.org/attachment.cgi?id=385048
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=385048&action=review

> Source/JavaScriptCore/inspector/ContentSearchUtilities.cpp:137
> +RegularExpression createMatchRegex(const String& query, bool caseSensitive,
bool isRegex)

Maybe name this `createExactMatchRegex`?

>> Source/WebCore/inspector/agents/InspectorNetworkAgent.cpp:858
>>	}
> 
> I'd expect to see:
> 
>     if (intercept.isRegex) {
>	  ... regex ...
>     } else {
>	  ... string compare ...
>     }

I see you answer this because `ContentSearchUtilities` is clever.