[webkit-reviews] review granted: [Bug 204720] [iOS] Calls to device orientation API should be done in the UI process : [Attachment 384965] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Dec 6 14:36:48 PST 2019


Alex Christensen <achristensen at apple.com> has granted Per Arne Vollan
<pvollan at apple.com>'s request for review:
Bug 204720: [iOS] Calls to device orientation API should be done in the UI
process
https://bugs.webkit.org/show_bug.cgi?id=204720

Attachment 384965: Patch

https://bugs.webkit.org/attachment.cgi?id=384965&action=review




--- Comment #28 from Alex Christensen <achristensen at apple.com> ---
Comment on attachment 384965
  --> https://bugs.webkit.org/attachment.cgi?id=384965
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=384965&action=review

> Source/WebCore/platform/ios/WebCoreMotionManager.mm:254
> +	       orientationClients.append(makeWeakPtr(&client));

This could be uncheckedAppend.


More information about the webkit-reviews mailing list