[webkit-reviews] review granted: [Bug 204873] [MSVC] writeNumberToBufferUnsigned is unsafe for bool type : [Attachment 384988] Patch

[bugzilla-daemon at webkit.org]

Darin Adler <darin at apple.com> has granted Fujii Hironori
<Hironori.Fujii at sony.com>'s request for review:
Bug 204873: [MSVC] writeNumberToBufferUnsigned is unsafe for bool type
https://bugs.webkit.org/show_bug.cgi?id=204873

Attachment 384988: Patch

https://bugs.webkit.org/attachment.cgi?id=384988&action=review




--- Comment #5 from Darin Adler <darin at apple.com> ---
Comment on attachment 384988
  --> https://bugs.webkit.org/attachment.cgi?id=384988
Patch

Looks fine. I probably would have said something more like “bool not supported”
rather than focusing on the implementation detail fo why this function template
won’t work