[webkit-reviews] review granted: [Bug 204715] [GTK] WebKitGTK build hangs on g-ir-scanner : [Attachment 385005] Patch

[bugzilla-daemon at webkit.org]

Carlos Garcia Campos <cgarcia at igalia.com> has granted Jim Mason
<jmason at ibinx.com>'s request for review:
Bug 204715: [GTK] WebKitGTK build hangs on g-ir-scanner
https://bugs.webkit.org/show_bug.cgi?id=204715

Attachment 385005: Patch

https://bugs.webkit.org/attachment.cgi?id=385005&action=review




--- Comment #5 from Carlos Garcia Campos <cgarcia at igalia.com> ---
Comment on attachment 385005
  --> https://bugs.webkit.org/attachment.cgi?id=385005
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=385005&action=review

> Source/JavaScriptCore/inspector/remote/RemoteInspector.h:181
> -    static const SocketConnection::MessageHandlers s_messageHandlers;
> +    static const SocketConnection::MessageHandlers& getMessageHandlers();

getMessageHandlers() -> messageHandlers()

> Source/JavaScriptCore/inspector/remote/glib/RemoteInspectorGlib.cpp:97
> +    static SocketConnection::MessageHandlers *messageHandlers = new
SocketConnection::MessageHandlers({

Use NeverDestroyed.