[webkit-reviews] review granted: [Bug 204941] [LFC][Integration] Support isLineBreak() in iterator : [Attachment 384999] patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Dec 6 05:10:53 PST 2019


zalan <zalan at apple.com> has granted Antti Koivisto <koivisto at iki.fi>'s request
for review:
Bug 204941: [LFC][Integration] Support isLineBreak() in iterator
https://bugs.webkit.org/show_bug.cgi?id=204941

Attachment 384999: patch

https://bugs.webkit.org/attachment.cgi?id=384999&action=review




--- Comment #2 from zalan <zalan at apple.com> ---
Comment on attachment 384999
  --> https://bugs.webkit.org/attachment.cgi?id=384999
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=384999&action=review

> Source/WebCore/layout/displaytree/DisplayRun.h:101
> +    bool isLineBreak() const { return layoutBox().isLineBreakBox() ||
(textContext() && textContext()->content() == "\n"); }

&& style().preserveNewline() 
We might need to start tracking type information in DisplayRuns.


More information about the webkit-reviews mailing list