[webkit-reviews] review granted: [Bug 204908] Add ThreadMessageReceiver to IPC::Connection : [Attachment 384939] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Thu Dec 5 14:15:55 PST 2019
Brady Eidson <beidson at apple.com> has granted Sihui Liu <sihui_liu at apple.com>'s
request for review:
Bug 204908: Add ThreadMessageReceiver to IPC::Connection
https://bugs.webkit.org/show_bug.cgi?id=204908
Attachment 384939: Patch
https://bugs.webkit.org/attachment.cgi?id=384939&action=review
--- Comment #2 from Brady Eidson <beidson at apple.com> ---
Comment on attachment 384939
--> https://bugs.webkit.org/attachment.cgi?id=384939
Patch
View in context: https://bugs.webkit.org/attachment.cgi?id=384939&action=review
It's weird to be adding dead code, but I happen to know it's in prep for
https://bugs.webkit.org/show_bug.cgi?id=203690
To make sure everybody knows, please reference in the ChangeLog
> Source/WebKit/Platform/IPC/Connection.h:341
> + Lock m_threadMessageReceiversMutex;
It's a lock, not a mutex. Let's name it as such.
More information about the webkit-reviews
mailing list