[webkit-reviews] review granted: [Bug 204905] [LFC][IFC] Introduce InlineSoftLineBreakItem : [Attachment 384935] Patch

[bugzilla-daemon at webkit.org]

Antti Koivisto <koivisto at iki.fi> has granted zalan <zalan at apple.com>'s request
for review:
Bug 204905: [LFC][IFC] Introduce InlineSoftLineBreakItem
https://bugs.webkit.org/show_bug.cgi?id=204905

Attachment 384935: Patch

https://bugs.webkit.org/attachment.cgi?id=384935&action=review




--- Comment #3 from Antti Koivisto <koivisto at iki.fi> ---
Comment on attachment 384935
  --> https://bugs.webkit.org/attachment.cgi?id=384935
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=384935&action=review

> Source/WebCore/layout/inlineformatting/InlineLineBuilder.cpp:537
> +    m_inlineItemRuns.append({ softLineBreakItem, contentLogicalWidth(), { },
Display::Run::TextContext { softLineBreakItem.position(), 0, emptyString() }
});

Lineboxes include '\n' character contained in the underlying string. Not sure
if/where that matters.

> Source/WebCore/layout/inlineformatting/InlineSoftLineBreakItem.h:35
> +class InlineSoftLineBreakItem : public InlineItem {

Feels like this could be combined into one LineBreak class with hard and soft
type.