[webkit-reviews] review requested: [Bug 204875] Web Inspector: add compiler UNLIKELY hints when checking if developer extras are enabled : [Attachment 384926] Patch

[bugzilla-daemon at webkit.org]

Devin Rousso <drousso at apple.com> has asked  for review:
Bug 204875: Web Inspector: add compiler UNLIKELY hints when checking if
developer extras are enabled
https://bugs.webkit.org/show_bug.cgi?id=204875

Attachment 384926: Patch

https://bugs.webkit.org/attachment.cgi?id=384926&action=review




--- Comment #3 from Devin Rousso <drousso at apple.com> ---
Created attachment 384926

  --> https://bugs.webkit.org/attachment.cgi?id=384926&action=review

Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=384883&action=review

>> Source/JavaScriptCore/inspector/JSGlobalObjectConsoleClient.cpp:68
>> +	if (LIKELY(m_consoleAgent->developerExtrasEnabled()))
> 
> Backwards? Should this be: if
(LIKELY(!m_consoleAgent->developerExtrasEnabled()))
> 
> Similar for the rest like this.

Oops :|