[webkit-reviews] review denied: [Bug 204875] Web Inspector: add compiler UNLIKELY hints when checking if developer extras are enabled : [Attachment 384883] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Dec 5 11:13:32 PST 2019


Timothy Hatcher <timothy at apple.com> has denied Devin Rousso
<drousso at apple.com>'s request for review:
Bug 204875: Web Inspector: add compiler UNLIKELY hints when checking if
developer extras are enabled
https://bugs.webkit.org/show_bug.cgi?id=204875

Attachment 384883: Patch

https://bugs.webkit.org/attachment.cgi?id=384883&action=review




--- Comment #2 from Timothy Hatcher <timothy at apple.com> ---
Comment on attachment 384883
  --> https://bugs.webkit.org/attachment.cgi?id=384883
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=384883&action=review

> Source/JavaScriptCore/inspector/JSGlobalObjectConsoleClient.cpp:68
> +    if (LIKELY(m_consoleAgent->developerExtrasEnabled()))

Backwards? Should this be: if
(LIKELY(!m_consoleAgent->developerExtrasEnabled()))

Similar for the rest like this.


More information about the webkit-reviews mailing list