[webkit-reviews] review granted: [Bug 204899] MESSAGE_CHECK BackForwardItemIdentifier on incoming IPC from the WebProcess : [Attachment 384916] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Thu Dec 5 11:11:47 PST 2019
Ryosuke Niwa <rniwa at webkit.org> has granted Chris Dumez <cdumez at apple.com>'s
request for review:
Bug 204899: MESSAGE_CHECK BackForwardItemIdentifier on incoming IPC from the
WebProcess
https://bugs.webkit.org/show_bug.cgi?id=204899
Attachment 384916: Patch
https://bugs.webkit.org/attachment.cgi?id=384916&action=review
--- Comment #3 from Ryosuke Niwa <rniwa at webkit.org> ---
Comment on attachment 384916
--> https://bugs.webkit.org/attachment.cgi?id=384916
Patch
View in context: https://bugs.webkit.org/attachment.cgi?id=384916&action=review
> Source/WebCore/history/BackForwardItemIdentifier.cpp:33
> + return HashTraits<BackForwardItemIdentifier>::emptyValue() != *this &&
!HashTraits<BackForwardItemIdentifier>::isDeletedValue(*this);
We don’t have isEmptyValue??
More information about the webkit-reviews
mailing list