[webkit-reviews] review denied: [Bug 204871] sched_yield can cause calling thread to be preempted for 10 ms on Darwin : [Attachment 384875] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Dec 4 20:43:25 PST 2019


Filip Pizlo <fpizlo at apple.com> has denied Ben Nham <nham at apple.com>'s request
for review:
Bug 204871: sched_yield can cause calling thread to be preempted for 10 ms on
Darwin
https://bugs.webkit.org/show_bug.cgi?id=204871

Attachment 384875: Patch

https://bugs.webkit.org/attachment.cgi?id=384875&action=review




--- Comment #9 from Filip Pizlo <fpizlo at apple.com> ---
Comment on attachment 384875
  --> https://bugs.webkit.org/attachment.cgi?id=384875
Patch

We have tried this change before. It was bad for perf. Unless you’ve got
overwhelming perf data, this ain’t a change we are going to land.


More information about the webkit-reviews mailing list