[webkit-reviews] review granted: [Bug 204869] run-javascriptcore-tests is failing to run testmasm of 64bit AppleWin on Buildbot : [Attachment 384872] Patch

[bugzilla-daemon at webkit.org]

Per Arne Vollan <pvollan at apple.com> has granted Fujii Hironori
<Hironori.Fujii at sony.com>'s request for review:
Bug 204869: run-javascriptcore-tests is failing to run testmasm of 64bit
AppleWin on Buildbot
https://bugs.webkit.org/show_bug.cgi?id=204869

Attachment 384872: Patch

https://bugs.webkit.org/attachment.cgi?id=384872&action=review




--- Comment #2 from Per Arne Vollan <pvollan at apple.com> ---
Comment on attachment 384872
  --> https://bugs.webkit.org/attachment.cgi?id=384872
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=384872&action=review

> Tools/Scripts/webkitdirs.pm:2276
> -    push @args, "-DDEVELOPER_MODE=ON" if isFTW() || isGtk() || isJSCOnly()
|| isWPE() || isWinCairo();
> +    push @args, "-DDEVELOPER_MODE=ON" if isJSCOnly() || isWPE() ||
isWin64();

Did you forget to keep isGtk()?