[webkit-reviews] review granted: [Bug 204866] Fix a broken assertion in GetByStatus::computeForStubInfoWithoutExitSiteFeedback(). : [Attachment 384868] proposed patch.

[bugzilla-daemon at webkit.org]

Saam Barati <sbarati at apple.com> has granted Mark Lam <mark.lam at apple.com>'s
request for review:
Bug 204866: Fix a broken assertion in
GetByStatus::computeForStubInfoWithoutExitSiteFeedback().
https://bugs.webkit.org/show_bug.cgi?id=204866

Attachment 384868: proposed patch.

https://bugs.webkit.org/attachment.cgi?id=384868&action=review




--- Comment #2 from Saam Barati <sbarati at apple.com> ---
Comment on attachment 384868
  --> https://bugs.webkit.org/attachment.cgi?id=384868
proposed patch.

View in context: https://bugs.webkit.org/attachment.cgi?id=384868&action=review

> Source/JavaScriptCore/bytecode/GetByStatus.cpp:295
> +		   ASSERT(access.isCustom() || ((AccessCase::Miss ==
access.type()) == (access.offset() == invalidOffset)));

you could also do:
ASSERT(((AccessCase::Miss == access.type() || access.isCustom()) ==
(access.offset() == invalidOffset)));