[webkit-reviews] review granted: [Bug 204857] [JSC] JSWebAssemblyGlobal creation should have exception check : [Attachment 384841] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Dec 4 13:26:52 PST 2019


Mark Lam <mark.lam at apple.com> has granted Yusuke Suzuki <ysuzuki at apple.com>'s
request for review:
Bug 204857: [JSC] JSWebAssemblyGlobal creation should have exception check
https://bugs.webkit.org/show_bug.cgi?id=204857

Attachment 384841: Patch

https://bugs.webkit.org/attachment.cgi?id=384841&action=review




--- Comment #4 from Mark Lam <mark.lam at apple.com> ---
Comment on attachment 384841
  --> https://bugs.webkit.org/attachment.cgi?id=384841
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=384841&action=review

r=me

> Source/JavaScriptCore/ChangeLog:10
> +	   in  WebAssemblyModuleRecord linking phase. While exception is never
thrown in this place since this happens only when WebAssembly is enabled, we
should put

Extra space between "in WebAssemblyModuleRecord".


More information about the webkit-reviews mailing list