[webkit-reviews] review granted: [Bug 204852] [LFC][Integration] Paint with TextPainter : [Attachment 384812] patch

[bugzilla-daemon at webkit.org]

zalan <zalan at apple.com> has granted Antti Koivisto <koivisto at iki.fi>'s request
for review:
Bug 204852: [LFC][Integration] Paint with TextPainter
https://bugs.webkit.org/show_bug.cgi?id=204852

Attachment 384812: patch

https://bugs.webkit.org/attachment.cgi?id=384812&action=review




--- Comment #4 from zalan <zalan at apple.com> ---
Comment on attachment 384812
  --> https://bugs.webkit.org/attachment.cgi?id=384812
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=384812&action=review

> Source/WebCore/layout/integration/LayoutIntegrationLineLayout.cpp:188
> +	   if (textContext.start() == textContext.end())

!textContext.length()

> Source/WebCore/layout/integration/LayoutIntegrationLineLayout.cpp:196
> +	   LayoutRect rect = run.logicalRect();
> +	   FloatRect visualOverflowRect = computeOverflow(style, rect,
viewportSize);

why no auto? (also in a few places further down)