[webkit-reviews] review requested: [Bug 204147] Handle page closure for stale-while-revalidate revalidations : [Attachment 384711] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Wed Dec 4 01:22:45 PST 2019
Rob Buis <rbuis at igalia.com> has asked for review:
Bug 204147: Handle page closure for stale-while-revalidate revalidations
https://bugs.webkit.org/show_bug.cgi?id=204147
Attachment 384711: Patch
https://bugs.webkit.org/attachment.cgi?id=384711&action=review
--- Comment #6 from Rob Buis <rbuis at igalia.com> ---
Comment on attachment 384711
--> https://bugs.webkit.org/attachment.cgi?id=384711
Patch
This still needs a test but I think it can be reviewed to check if it is the
right direction. Some remarks:
- I picked stopAllLoaders to catch both page close and starting a new
navigation within a page.
- I do not like adding another HashMap but I think it is hard to avoid.
- The cleanup only gets triggered for main frames.
More information about the webkit-reviews
mailing list