[webkit-reviews] review denied: [Bug 197646] AX: css transform causes VO focus border drawn incorrectly : [Attachment 369229] Patch

[bugzilla-daemon at webkit.org]

Ryosuke Niwa <rniwa at webkit.org> has denied Eric Liang <ericliang at apple.com>'s
request for review:
Bug 197646: AX: css transform causes VO focus border drawn incorrectly
https://bugs.webkit.org/show_bug.cgi?id=197646

Attachment 369229: Patch

https://bugs.webkit.org/attachment.cgi?id=369229&action=review




--- Comment #13 from Ryosuke Niwa <rniwa at webkit.org> ---
Comment on attachment 369229
  --> https://bugs.webkit.org/attachment.cgi?id=369229
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=369229&action=review

r- due to the lack of explaining & new tests.

> Source/WebCore/ChangeLog:3
> +	   Size for accessibility links should not query hierarchy below the
link because its ring should bound to itself. 

This line should match the bugzilla bug title.

> Source/WebCore/ChangeLog:8
> +	   Tests updated

Given that the original bug says this is about CSS transforms,
we need new tests with CSS transforms, which demonstrates the issue at hand.

> Source/WebCore/ChangeLog:9
> +

Please explain how the bug was caused & how you're fixing it.

> LayoutTests/ChangeLog:3
> +	   Size for accessibility links should not query hierarchy below the
link because its ring should bound to itself.

Ditto.