[webkit-reviews] review granted: [Bug 204809] Add disabled highlight API skeleton : [Attachment 384768] Patch

[bugzilla-daemon at webkit.org]

Alex Christensen <achristensen at apple.com> has granted Megan Gardner
<megan_gardner at apple.com>'s request for review:
Bug 204809: Add disabled highlight API skeleton
https://bugs.webkit.org/show_bug.cgi?id=204809

Attachment 384768: Patch

https://bugs.webkit.org/attachment.cgi?id=384768&action=review




--- Comment #7 from Alex Christensen <achristensen at apple.com> ---
Comment on attachment 384768
  --> https://bugs.webkit.org/attachment.cgi?id=384768
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=384768&action=review

> Source/WebCore/Modules/highlight/HighlightMap.cpp:2
> +* Copyright (C) 2019 Apple Inc. All rights reserved.

There should be a space before the *
Same for a few files in this.

> Source/WebCore/Modules/highlight/HighlightMap.cpp:36
> +

extra space

> Source/WebCore/Modules/highlight/HighlightMap.cpp:49
> +

ditto

> Source/WebCore/Modules/highlight/HighlightRangeGroup.h:34
> +

ditto

> Source/WebKitLegacy/mac/WebView/WebView.mm:3135
> +   
RuntimeEnabledFeatures::sharedFeatures().setHighlightAPIEnabled([preferences
highlightAPIEnabled]);

Windows WebKitLegacy will be running these tests.  Do we want to skip all the
tests or implement it on Windows?