[webkit-reviews] review granted: [Bug 204546] Perform microtask checkpoint after each task as spec'ed : [Attachment 384232] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Dec 3 16:43:30 PST 2019


Chris Dumez <cdumez at apple.com> has granted Ryosuke Niwa <rniwa at webkit.org>'s
request for review:
Bug 204546: Perform microtask checkpoint after each task as spec'ed
https://bugs.webkit.org/show_bug.cgi?id=204546

Attachment 384232: Patch

https://bugs.webkit.org/attachment.cgi?id=384232&action=review




--- Comment #6 from Chris Dumez <cdumez at apple.com> ---
Comment on attachment 384232
  --> https://bugs.webkit.org/attachment.cgi?id=384232
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=384232&action=review

> Source/WebCore/dom/EventLoop.cpp:85
> +	   m_groupsWithSuspenedTasks.clear();

typo: m_groupsWithSuspenedTasks -> m_groupsWithSuspendedTasks

> Source/WebCore/testing/Internals.h:780
> +    ExceptionOr<void> queueMicrotaskInTask(Document&, const String& source,
RefPtr<VoidCallback>&&);

Kind of a strange name IMHO.


More information about the webkit-reviews mailing list