[webkit-reviews] review granted: [Bug 204779] Resource Load Statistics (experimental): Delete non-cookie website data after 7 days of no user interaction : [Attachment 384681] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Dec 3 15:49:26 PST 2019


Alex Christensen <achristensen at apple.com> has granted John Wilander
<wilander at apple.com>'s request for review:
Bug 204779: Resource Load Statistics (experimental): Delete non-cookie website
data after 7 days of no user interaction
https://bugs.webkit.org/show_bug.cgi?id=204779

Attachment 384681: Patch

https://bugs.webkit.org/attachment.cgi?id=384681&action=review




--- Comment #4 from Alex Christensen <achristensen at apple.com> ---
Comment on attachment 384681
  --> https://bugs.webkit.org/attachment.cgi?id=384681
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=384681&action=review

>
Source/WebKit/NetworkProcess/Classifier/WebResourceLoadStatisticsStore.cpp:488
> +    postTask([this, mode, completionHandler = WTFMove(completionHandler)]()
mutable {

Not for this patch, but I don't like it how in this one file it's ok to use
this without protecting it or checking a weak pointer, but everywhere else we
need to be careful.  Let's make it so postTask doesn't implicitly protect this
and require all callers to protect this.


More information about the webkit-reviews mailing list