[webkit-reviews] review granted: [Bug 204792] WebProcessPool::terminateServiceWorkerProcess should be renamed terminateServiceWorkers : [Attachment 384709] Patch

[bugzilla-daemon at webkit.org]

Chris Dumez <cdumez at apple.com> has granted youenn fablet <youennf at gmail.com>'s
request for review:
Bug 204792: WebProcessPool::terminateServiceWorkerProcess should be renamed
terminateServiceWorkers
https://bugs.webkit.org/show_bug.cgi?id=204792

Attachment 384709: Patch

https://bugs.webkit.org/attachment.cgi?id=384709&action=review




--- Comment #2 from Chris Dumez <cdumez at apple.com> ---
Comment on attachment 384709
  --> https://bugs.webkit.org/attachment.cgi?id=384709
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=384709&action=review

> Source/WebKit/UIProcess/WebProcessPool.cpp:-1733
> -    auto protectedThis = makeRef(*this);

Why drop this? Seems safer to protect ourselves as we iterate.