[webkit-reviews] review granted: [Bug 204765] Adopt AVContentKeyReportGroup : [Attachment 384716] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Dec 3 11:09:30 PST 2019


Eric Carlson <eric.carlson at apple.com> has granted Jer Noble
<jer.noble at apple.com>'s request for review:
Bug 204765: Adopt AVContentKeyReportGroup
https://bugs.webkit.org/show_bug.cgi?id=204765

Attachment 384716: Patch

https://bugs.webkit.org/attachment.cgi?id=384716&action=review




--- Comment #3 from Eric Carlson <eric.carlson at apple.com> ---
Comment on attachment 384716
  --> https://bugs.webkit.org/attachment.cgi?id=384716
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=384716&action=review

> Source/WebCore/ChangeLog:11
> +	   AVContentKeySession to continue working for platform versions
without report group support.

"... existing usage of AVContentKeySession to continue working ..." isn't quite
right. 

Maybe "... existing usage of AVContentKeySession continues to work ..."?

> Source/WebCore/WebCore.xcodeproj/project.pbxproj:22955
> +				CD53555723748E5900A613BD /*
MediaToolboxSoftLink.cpp */,
> +				CD53555623748E5900A613BD /*
MediaToolboxSoftLink.h */,

Are these necessary?


More information about the webkit-reviews mailing list