[webkit-reviews] review granted: [Bug 204762] WPT test MediaStream-MediaElement-srcObject.https.html times out : [Attachment 384722] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Dec 3 10:58:54 PST 2019


youenn fablet <youennf at gmail.com> has granted Eric Carlson
<eric.carlson at apple.com>'s request for review:
Bug 204762: WPT test MediaStream-MediaElement-srcObject.https.html times out
https://bugs.webkit.org/show_bug.cgi?id=204762

Attachment 384722: Patch

https://bugs.webkit.org/attachment.cgi?id=384722&action=review




--- Comment #3 from youenn fablet <youennf at gmail.com> ---
Comment on attachment 384722
  --> https://bugs.webkit.org/attachment.cgi?id=384722
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=384722&action=review

> Source/WebCore/html/HTMLMediaElement.cpp:4858
> +	   if (loop() && !m_mediaController && playbackRate > 0 &&
!hasMediaStreamSrcObject()) {

Should loop() (or a hasLoop() variant) always return false if there is a media
stream src object?

>
Source/WebCore/platform/graphics/avfoundation/objc/MediaPlayerPrivateMediaStrea
mAVFObjC.mm:830
> +		       m_player->durationChanged();

Should we introduce a player routine to do all these things together (if player
knows it is ended)?

> LayoutTests/TestExpectations:3880
>
+imported/w3c/web-platform-tests/mediacapture-streams/MediaStream-MediaElement-
srcObject.https.html [ Failure ]

We could update the test to do assert_true( ===). instead of assert_equal(, ).
That would be good to ensure we do not regress this test.
Either as part of this patch or as a follow-up that we would upstream to WPT.


More information about the webkit-reviews mailing list