[webkit-reviews] review granted: [Bug 204786] UserMediaCaptureManager should have independent capture factories : [Attachment 384698] Patch

[bugzilla-daemon at webkit.org]

Eric Carlson <eric.carlson at apple.com> has granted youenn fablet
<youennf at gmail.com>'s request for review:
Bug 204786: UserMediaCaptureManager should have independent capture factories
https://bugs.webkit.org/show_bug.cgi?id=204786

Attachment 384698: Patch

https://bugs.webkit.org/attachment.cgi?id=384698&action=review




--- Comment #2 from Eric Carlson <eric.carlson at apple.com> ---
Comment on attachment 384698
  --> https://bugs.webkit.org/attachment.cgi?id=384698
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=384698&action=review

> Source/WebKit/WebProcess/cocoa/UserMediaCaptureManager.cpp:101
> +	   case CaptureDevice::DeviceType::Unknown:

Nit: this should ASSERT_NOT_REACHED as the constructor does.