[webkit-reviews] review granted: [Bug 204778] run-jsc should exit with the same signal or exit status that the `jsc` shell does : [Attachment 384677] patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Dec 2 19:09:02 PST 2019


Keith Miller <keith_miller at apple.com> has granted Saam Barati
<sbarati at apple.com>'s request for review:
Bug 204778: run-jsc should exit with the same signal or exit status that the
`jsc` shell does
https://bugs.webkit.org/show_bug.cgi?id=204778

Attachment 384677: patch

https://bugs.webkit.org/attachment.cgi?id=384677&action=review




--- Comment #2 from Keith Miller <keith_miller at apple.com> ---
Comment on attachment 384677
  --> https://bugs.webkit.org/attachment.cgi?id=384677
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=384677&action=review

r=me

> Tools/Scripts/run-jsc:70
> +	   system("kill -" . $signal . " " . $PID); # We kill ourselves with
the same signal that the `jsc` process was killed with to make it look like
`jsc` was directly invoked.

Beautiful!


More information about the webkit-reviews mailing list