[webkit-reviews] review granted: [Bug 204531] Web Inspector: TabActivity diagnostic event should sample the active tab uniformly : [Attachment 384473] Patch

[bugzilla-daemon at webkit.org]

Devin Rousso <drousso at apple.com> has granted Brian Burg <bburg at apple.com>'s
request for review:
Bug 204531: Web Inspector: TabActivity diagnostic event should sample the
active tab uniformly
https://bugs.webkit.org/show_bug.cgi?id=204531

Attachment 384473: Patch

https://bugs.webkit.org/attachment.cgi?id=384473&action=review




--- Comment #6 from Devin Rousso <drousso at apple.com> ---
Comment on attachment 384473
  --> https://bugs.webkit.org/attachment.cgi?id=384473
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=384473&action=review

r=me

>
Source/WebInspectorUI/UserInterface/Controllers/TabActivityDiagnosticEventRecor
der.js:106
> +	   let initialDelay = remainingTime > 0 ? remainingTime :
maximumInitialDelay;

`Math.max(remainingTime, maximumInitialDelay)`

NIT: you could inline also this

>
Source/WebInspectorUI/UserInterface/Controllers/TabActivityDiagnosticEventRecor
der.js:196
> +WI.TabActivityDiagnosticEventRecorder.EventSamplingInterval = 60 * 1000;
> +WI.TabActivityDiagnosticEventRecorder.InitialDelayBeforeSamplingInterval =
10 * 1000;

NIT: I've started using `static get` instead of creating these as a named
property after the class' structure is defined.