[webkit-reviews] review granted: [Bug 188514] WebDriver: handle elements of type file in send keys command : [Attachment 384403] Patch

[bugzilla-daemon at webkit.org]

Brian Burg <bburg at apple.com> has granted Carlos Garcia Campos
<cgarcia at igalia.com>'s request for review:
Bug 188514: WebDriver: handle elements of type file in send keys command
https://bugs.webkit.org/show_bug.cgi?id=188514

Attachment 384403: Patch

https://bugs.webkit.org/attachment.cgi?id=384403&action=review




--- Comment #11 from Brian Burg <bburg at apple.com> ---
Comment on attachment 384403
  --> https://bugs.webkit.org/attachment.cgi?id=384403
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=384403&action=review

r=me

> Source/WebDriver/Session.cpp:1569
> +Session::IsFileUpload Session::parseElementIsFileUploadResult(const
RefPtr<JSON::Value>& resultValue)

I would have encoded it as Optional<FileUploadType> and have FileUploadType be
one of {Single, Multiple}.

> Source/WebKit/ChangeLog:9
> +	   differently, so I'm keeping both to not break safari driver. The new
one simply sends the file list ot the web

Typo: ot -> to, safari driver -> safaridriver.

> Source/WebKit/ChangeLog:11
> +	   panel, intercept and complete the open panel request and send a
dismiss open panel event to the driver.

I don't recall offhand why I didn't pursue an approach like yours. Perhaps it
was related to sandboxing not being able to open the file without going through
the file chooser path (which grants a sandbox exception for the selected
files)?