[webkit-reviews] review granted: [Bug 204771] [JSC] Put some destructible objects to IsoSubspace : [Attachment 384664] Patch

[bugzilla-daemon at webkit.org]

Mark Lam <mark.lam at apple.com> has granted Yusuke Suzuki <ysuzuki at apple.com>'s
request for review:
Bug 204771: [JSC] Put some destructible objects to IsoSubspace
https://bugs.webkit.org/show_bug.cgi?id=204771

Attachment 384664: Patch

https://bugs.webkit.org/attachment.cgi?id=384664&action=review




--- Comment #2 from Mark Lam <mark.lam at apple.com> ---
Comment on attachment 384664
  --> https://bugs.webkit.org/attachment.cgi?id=384664
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=384664&action=review

r=me if tests pass.

> Source/JavaScriptCore/runtime/DateInstance.h:89
> +    JS_EXPORT_PRIVATE DateInstance(VM&, Structure*);
> +    void finishCreation(VM&);
> +    JS_EXPORT_PRIVATE void finishCreation(VM&, double);

nit: can you put these above the 2 calculate functions above.  I think we
typically have the constructors come first.