[webkit-reviews] review granted: [Bug 204758] Add helper methods for description and equality to text manipulation SPI : [Attachment 384650] 57438200-part-2.patch

[bugzilla-daemon at webkit.org]

Wenson Hsieh <wenson_hsieh at apple.com> has granted Louie Livon-Bemel
<llivonbemel at apple.com>'s request for review:
Bug 204758: Add helper methods for description and equality to text
manipulation SPI
https://bugs.webkit.org/show_bug.cgi?id=204758

Attachment 384650: 57438200-part-2.patch

https://bugs.webkit.org/attachment.cgi?id=384650&action=review




--- Comment #7 from Wenson Hsieh <wenson_hsieh at apple.com> ---
Comment on attachment 384650
  --> https://bugs.webkit.org/attachment.cgi?id=384650
57438200-part-2.patch

View in context: https://bugs.webkit.org/attachment.cgi?id=384650&action=review

LGTM, with a couple of very minor comments.

> Source/WebKit/ChangeLog:35
> +	       The general description for should not include the webpage
content.

Nit - “…description for should not…”

> Source/WebKit/UIProcess/API/Cocoa/_WKTextManipulationItem.mm:27
>  #import "_WKTextManipulationItem.h"

Nit - we typically leave a newline below the primary header.