[webkit-reviews] review granted: [Bug 204708] Build ANGLE as a dynamic library : [Attachment 384551] Patch

[bugzilla-daemon at webkit.org]

Tim Horton <thorton at apple.com> has granted Dean Jackson <dino at apple.com>'s
request for review:
Bug 204708: Build ANGLE as a dynamic library
https://bugs.webkit.org/show_bug.cgi?id=204708

Attachment 384551: Patch

https://bugs.webkit.org/attachment.cgi?id=384551&action=review




--- Comment #16 from Tim Horton <thorton at apple.com> ---
Comment on attachment 384551
  --> https://bugs.webkit.org/attachment.cgi?id=384551
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=384551&action=review

> Source/ThirdParty/ANGLE/Configurations/ANGLE.xcconfig:10
> +ANGLE_OTHER_LDFLAGS_iphonesimulator = -framework OpenGLES;

Why no IOSurface here? We use it in the sim now everywhere else.

> Source/ThirdParty/ANGLE/Configurations/Base.xcconfig:22
> +CLANG_WARN__DUPLICATE_METHOD_MATCH = YES;

This one seems odd. is this strict selector matching?

> Source/ThirdParty/ANGLE/Configurations/Version.xcconfig:23
> +

Do you need to tell someone this is here so they update it?